feat(logo): add deepin_small ASCII logo#2350
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR successfully implements the 'deepin_small' ASCII logo; however, it does not currently comply with the project's contribution guidelines.
Specifically, the PR description is empty, and the mandatory 'Related issue' link (Closes #) is missing. The project guidelines explicitly state that new logos must be linked to an existing issue for acceptance. Furthermore, no screenshots were provided to verify the visual rendering of the 3-line ASCII art.
While the code implementation is straightforward, these administrative gaps must be addressed before merging.
About this PR
- Populate the 'Related issue' field (e.g., Closes #XX). Project guidelines require new logos to be linked to an existing issue.
- Please provide a PR description summarizing the changes and including screenshots of the rendered ASCII logo.
Test suggestions
- Validate that the 'Deepin_small' name correctly maps to the ASCII data in the logo selection logic.
- Verify the visual rendering of the 3-line ASCII art in the terminal.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate that the 'Deepin_small' name correctly maps to the ASCII data in the logo selection logic.
2. Verify the visual rendering of the 3-line ASCII art in the terminal.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
What original image logo is this small ASCII logo based on? |
Summary
Related issue (required for new logos for new distros)
Closes #
Changes
Screenshots
Checklist