Open
Conversation
Collaborator
|
Hi thanks for the PR! Give us a couple days to take a look and we will get back to you with any questions/concerns or a ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement remote_tags and implement_digest_tag arguments to k8s_deploy
Description
There are already stubs for an
image_digest_tagoption, which is documented to tag all pushes with the short digest. Here I implement the option. I've also added a remote_tags option so we can set it to push tolatestetc. as well.Related Issue
Fixes #59
Motivation and Context
Many container registries will garbage collect images pushed without a tag, tagging pushes with a hash is an easy way to avoid that issue.
How Has This Been Tested?
We are currently using this patch in our OpenShift deployment.
Types of changes
Checklist: