Remove unused Click code#1601
Merged
svlandeg merged 22 commits intofastapi:drop-clickfrom Mar 24, 2026
Merged
Conversation
Contributor
📝 Docs previewLast commit 7d572f2 at: https://44bba31e.typertiangolo.pages.dev |
svlandeg
commented
Feb 23, 2026
github-actions
bot
added
the
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
conflicts
svlandeg
changed the title
svlandeg
commented
Mar 24, 2026
Member
Author
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Discussed this one internally with Sebastián and he said it's good to merge, it's into a feature branch anyway so I'll merge and continue with this WIP in the next PR. 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue work from #1525, vendoring Click.
This PR removes Click code that Typer doesn't use and isn't currently documented/tested.
No Typer code is changed and no additional tests added (yet).
Removed Click's functionality:
CommandCollectionto_info_dict()funtionsopen_file(),KeepOpenFileUnprocessedParamTypepager,_pipepager,_tempfilepager,_nullpager,echo_via_pagerEditor,edit()pause(),unstyle()andclear()_check_nested_chain_MultiCommand,_BaseCommand,_FakeSubclassCheckAll original Typer tests from the test suite continue to succeed after these edits.
Coverage stats
On current
master:This branch, before this PR:
This branch, after this PR: