fix: store OAuth expiration timestamps as bigint - #32
Open
MarthalaJagruthiReddy wants to merge 1 commit into
Open
fix: store OAuth expiration timestamps as bigint#32MarthalaJagruthiReddy wants to merge 1 commit into
MarthalaJagruthiReddy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fastapi-users/fastapi-users#1296
OAuthAccount.expires_atwas mapped to SQLINTEGER, which cannot store valid OAuth expiry timestamps beyond the signed 32-bit range. Map it toBigIntegerinstead.The regression test persists a 2043-era timestamp and verifies the value round-trips, while also asserting the SQLAlchemy column type.
Validation:
python -m pytest -qpython -m mypy fastapi_users_db_sqlalchemy/python -m ruff format --check .BIGINT