feat: support parser rounding modes - #24
Open
tisonkun wants to merge 8 commits into
Open
Conversation
…unding # Conflicts: # bsize/src/parse.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoundModewith five non-redundant modes:Ceil,Floor,HalfCeil,HalfFloor, andHalfEven.ParseOptionswith a publicround_modefield andHalfCeilas its default.ByteSize::parse_with(input, options); standard and Serde string parsing preserve the existing ties-to-larger behavior.FromStrandparse_with.cargo x test,cargo x lint, andcargo x bench.Design Notes
The rounding semantics are adapted from Jiff’s
RoundMode, but the API does not copy all nine variants.ByteSizeonly accepts non-negative values, makingExpandequivalent toCeil,Truncequivalent toFloor,HalfExpandequivalent toHalfCeil, andHalfTruncequivalent toHalfFloor. The public enum keeps one direction-based name for each distinct behavior relevant to this domain.The parsing API follows the cronexpr
ParseOptionspattern: configurable behavior lives in a defaultable, non-exhaustive options type.FromStruses the sameHalfCeilcontract through a zero-sized internal strategy, whileparse_withuses the selected runtime mode. This preserves one parsing algorithm without carrying runtime mode state through the default integer scan.Controlled same-machine A/B runs used matching benchmark binaries and at least one second per case. Against
main, every existingFromStrcase was at parity or faster: high-precision decimal parsing improved by about 17%, high-precision binary by about 1%, and the remaining cases by about 1–11%. Against the pre-optimization PR head, all fiveparse_withmodes improved by about 8–14%.