Skip to content

fix(UNC): backup device type#122

Open
mja9 wants to merge 2 commits intomasterfrom
fix/backup/device-type
Open

fix(UNC): backup device type#122
mja9 wants to merge 2 commits intomasterfrom
fix/backup/device-type

Conversation

@mja9
Copy link
Collaborator

@mja9 mja9 commented Feb 25, 2026

Experienced an issue where backup device type was being misidentified as URL because of UNC format.

@mja9 mja9 self-assigned this Feb 25, 2026
@RicoFactset
Copy link

RicoFactset commented Feb 25, 2026

Logo
Checkmarx One – Scan Summary & Details5fb18622-1512-4f2e-b759-0581618db3cf


New Issues (14) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Missing_Column_Encryption /src/SmoFacade/Server.cs: 375
detailsColumn encryption was not set or found in the connection string in file /src/SmoFacade/Server.cs at line 376. That means that the application wil...
ID: P2NGHM%2FCALl64o%2F%2BDXsVLCBlt24%3D
Attack Vector
2 LOW Improper_Exception_Handling /src/SmoFacade/Server.cs: 91
detailsThe method RemainingDiskMb at line 91 of /src/SmoFacade/Server.cs performs an operation that could be expected to throw an exception, and is not p...
ID: MT%2B2PCiOXSkJhNLGSixMhqeVDO0%3D
Attack Vector
3 LOW Improper_Exception_Handling /src/SmoFacade/Server.cs: 75
detailsThe method DatabaseSizeMb at line 75 of /src/SmoFacade/Server.cs performs an operation that could be expected to throw an exception, and is not pr...
ID: AGfvcBsxDlUmsnO25eT866mdBnM%3D
Attack Vector
4 LOW Improper_Exception_Handling /src/SmoFacade/Login.cs: 67
detailsThe method PasswordHash at line 67 of /src/SmoFacade/Login.cs performs an operation that could be expected to throw an exception, and is not prope...
ID: D9cRY%2Ff%2B1ef7Po6kC4K85KgP%2FcQ%3D
Attack Vector
5 LOW Improper_Exception_Handling /src/SmoFacade/Server.cs: 379
detailsThe method CheckDBConnection at line 379 of /src/SmoFacade/Server.cs performs an operation that could be expected to throw an exception, and is no...
ID: RqKDihJtwaa0e0NDuu2ry3zWccg%3D
Attack Vector
6 LOW Improper_Exception_Handling /src/SmoFacade/Database.cs: 204
detailsThe method BackupChainFromLsn at line 204 of /src/SmoFacade/Database.cs performs an operation that could be expected to throw an exception, and is...
ID: UzWofzllDNdJyqm3wZ7wfaDtAq8%3D
Attack Vector
7 LOW Improper_Exception_Handling /src/SmoFacade/Server.cs: 152
detailsThe method BackupDirectoryOrDefault at line 152 of /src/SmoFacade/Server.cs performs an operation that could be expected to throw an exception, an...
ID: WMTjYXURL%2FP%2BRF0WBEg7k%2FuoPeA%3D
Attack Vector
8 LOW Improper_Exception_Handling /src/SmoFacade/Server.cs: 131
detailsThe method DefaultFileLocations at line 131 of /src/SmoFacade/Server.cs performs an operation that could be expected to throw an exception, and is...
ID: djI6g4peh9USeEpAmr%2F6vhkdFV8%3D
Attack Vector
9 LOW Improper_Exception_Handling /src/SmoFacade/Database.cs: 168
detailsThe method MostRecentFullBackupLsn at line 168 of /src/SmoFacade/Database.cs performs an operation that could be expected to throw an exception, a...
ID: RwF39XcEyqG%2F1li1YNcnjiSgJcw%3D
Attack Vector
10 LOW Improper_Exception_Handling /src/SmoFacade/Database.cs: 135
detailsThe method MostRecentBackupChain at line 135 of /src/SmoFacade/Database.cs performs an operation that could be expected to throw an exception, and...
ID: vpBGkLDJ2c8Eu%2F3X7a%2BUH0773PA%3D
Attack Vector
11 LOW Improper_Resource_Shutdown_or_Release /src/AgDatabaseMove.Cli/Program.cs: 29
detailsThe application's Main method in /src/AgDatabaseMove.Cli/Program.cs defines and initializes the AgDatabase object at 29. This object encapsulate...
ID: 7Ik5S4IjBDnnsvm1MdGAYnKGs4o%3D
Attack Vector
12 LOW Improper_Resource_Shutdown_or_Release /src/AgDatabaseMove.Cli/Program.cs: 30
detailsThe application's Main method in /src/AgDatabaseMove.Cli/Program.cs defines and initializes the AgDatabase object at 30. This object encapsulate...
ID: iMYNser104hdrKb2%2FFi8mWXxEio%3D
Attack Vector
13 LOW Improper_Resource_Shutdown_or_Release /src/SmoFacade/Login.cs: 61
detailsThe application's PasswordHash method in /src/SmoFacade/Login.cs defines and initializes the SqlCommand object at 61. This object encapsulates a ...
ID: CMVd%2Fjw1ExSmdP9Uo5No%2F5BfzoM%3D
Attack Vector
14 LOW Improper_Resource_Shutdown_or_Release /src/SmoFacade/Server.cs: 28
detailsThe application's Server method in /src/SmoFacade/Server.cs defines and initializes the SqlConnection object at 28. This object encapsulates a li...
ID: vZ1jk0anfAsJLFePuJEOLgc8uoU%3D
Attack Vector

Fixed Issues (2) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM Insufficiently_Protected_Credentials /src/SmoFacade/Login.cs: 67
LOW Heap_Inspection /tests/AgDatabaseMove.Integration/Fixtures/TestAgDatabaseFixture.cs: 35

Communicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here.

@mja9 mja9 changed the title fix(backup): device type fix(UNC): backup device type Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants