Resolve date variables in report headers and footers - #144
Open
shishir-cyber wants to merge 1 commit into
Open
Conversation
replaceHeaderAndFooter previously only received the plain-text
replacements map, not the date map used by replacementText for the
document body, so ${today}, ${asmtStart}, and ${asmtEnd} were never
resolved inside headers/footers. Pass the date map through and run
replaceDateVariable against header/footer XML before the existing
plain-text replace pass, so both default and custom date formats
resolve the same way they already do in the body.
Fixes factionsecurity#143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaceHeaderAndFooter previously only received the plain-text replacements map, not the date map used by replacementText for the document body, so ${today}, ${asmtStart}, and ${asmtEnd} were never resolved inside headers/footers. Pass the date map through and run replaceDateVariable against header/footer XML before the existing plain-text replace pass, so both default and custom date formats resolve the same way they already do in the body.
Added DocxHeaderFooterDateTest, covering both the default date format and a custom format (${today MM-dd-yyyy}) in a header, generated through the real DocxUtils.generateDocx(...) path. Full suite passes (973 tests, 0 failures).
Fixes #143