remove X6 huffman decoder from legacy v0.2 - #4780
Merged
Merged
Conversation
The fast loop in HUF_decompress4X6_usingDTable was an experiment, if did not prove successful and was removed in v0.3. Meanwhile, the code is complex, and adds to attack surface. The work is done by remaining decoders which produce identical output.
terrelln
approved these changes
Sep 10, 2026
Yes, that's better Co-authored-by: Nick Terrell <terrelln@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fast loop in
HUF_decompress4X6_usingDTablewas an experiment,it did not prove successful and was removed in
v0.3.Meanwhile, its code is complex, and adds to attack surface.
The remaining decoders can do the work and produce identical output.