fix: division by zero in zstdcli_trace - #4761
Open
VirajMishra1 wants to merge 1 commit into
Open
Conversation
Guard against division by zero when trace data has zero-valued denominators. This can occur when --trace is used with certain inputs. Fixes facebook#4368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
programs/zstdcli_trace.c, the ratio calculation dividesuncompressedSizebycompressedSizewithout guarding againstcompressedSize == 0. This causes a floating-point division by zero when--traceis used with inputs that produce zero compressed bytes.Line 84 already guards
durationwith a ternary for the same reason. This fix applies the same pattern to theratiocalculation on line 85: whencompressedSizeis 0,ratiois set to 0.0 instead of dividing.This matches the approach suggested by the reviewer on the prior attempt (#4379).
Fixes #4368