Add granular CMake targets with BUILD_SHARED_LIBS support #247
+1,221
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Similar to the folly and fizz granular CMake implementations, this adds granular library targets for wangle that work with both static and shared library builds. Key changes: - Added WangleFunctions.cmake with wangle_add_library() function - Creates OBJECT libraries for compile-once, use-many pattern - Creates STATIC libraries (static builds) or INTERFACE libraries linking to monolithic wangle (shared builds) - Added generate_cmake.py to auto-generate CMakeLists.txt from BUCK files - Added lint_cmake_sync.py for arc lint integration - Updated main CMakeLists.txt with FetchContent compatibility and add_subdirectory() calls for all component directories The granular targets install as separate static libraries while maintaining backward compatibility through the monolithic wangle library. Reviewed By: mjoras Differential Revision: D91009052
afrind
force-pushed
the
export-D91009052
branch
from
6f69f18 to
11dd44f
Compare
|
This pull request has been merged in dbc2824. |
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 30, 2026
Summary: X-link: facebook/wangle#247 Similar to the folly and fizz granular CMake implementations, this adds granular library targets for wangle that work with both static and shared library builds. Key changes: - Added WangleFunctions.cmake with wangle_add_library() function - Creates OBJECT libraries for compile-once, use-many pattern - Creates STATIC libraries (static builds) or INTERFACE libraries linking to monolithic wangle (shared builds) - Added generate_cmake.py to auto-generate CMakeLists.txt from BUCK files - Added lint_cmake_sync.py for arc lint integration - Updated main CMakeLists.txt with FetchContent compatibility and add_subdirectory() calls for all component directories The granular targets install as separate static libraries while maintaining backward compatibility through the monolithic wangle library. Reviewed By: mjoras Differential Revision: D91009052 fbshipit-source-id: b4657f5219f85841dba144f4788c5a1aafabf504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Similar to the folly and fizz granular CMake implementations, this adds
granular library targets for wangle that work with both static and
shared library builds.
Key changes:
to monolithic wangle (shared builds)
add_subdirectory() calls for all component directories
The granular targets install as separate static libraries while maintaining
backward compatibility through the monolithic wangle library.
Differential Revision: D91009052