Skip to content

add a claude skill for adding a new feature#14389

Closed
xingbowang wants to merge 1 commit intofacebook:mainfrom
xingbowang:2026_02_25_cc
Closed

add a claude skill for adding a new feature#14389
xingbowang wants to merge 1 commit intofacebook:mainfrom
xingbowang:2026_02_25_cc

Conversation

@xingbowang
Copy link
Copy Markdown
Contributor

Summary:

I have found this skill to be quite helpful for both adding a new feature or even asking questions about certain details. It is able to do a good job dive deep into component.
Usage: /add_feature

Test:

Local claude

@meta-cla meta-cla Bot added the CLA Signed label Feb 25, 2026
@github-actions
Copy link
Copy Markdown

✅ clang-tidy: No findings on changed lines

Completed in 0.0s.

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 25, 2026

@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D94368806.

Copy link
Copy Markdown
Contributor

@hx235 hx235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant about incorporating broad, soft aspects of software engineering or general problem-solving guidance into a RocksDB project-specific claude.md. Doing so risks diluting the context, which should primarily serve to guide code generation toward the "right" approach—especially in areas not enforced by compilation. For example, see #14360 (comment).

Claude is rapidly evolving to behave more like a professional software engineer. I expect that much of the guidance currently written in the markdown file will soon be absorbed by the model itself.

In my experience, even without a standardized claude.md in the RocksDB repo (aside from custom versions I create as needed), the relevant phases and practices emerge naturally during interactions. Therefore, I don't see a strong need to add a general-purpose claude.md to the RocksDB repository.

@xingbowang xingbowang marked this pull request as ready for review February 25, 2026 16:36
Copy link
Copy Markdown
Contributor

@hx235 hx235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xingbowang
Copy link
Copy Markdown
Contributor Author

I'm hesitant about incorporating broad, soft aspects of software engineering or general problem-solving guidance into a RocksDB project-specific claude.md. Doing so risks diluting the context, which should primarily serve to guide code generation toward the "right" approach—especially in areas not enforced by compilation. For example, see #14360 (comment).

Claude is rapidly evolving to behave more like a professional software engineer. I expect that much of the guidance currently written in the markdown file will soon be absorbed by the model itself.

In my experience, even without a standardized claude.md in the RocksDB repo (aside from custom versions I create as needed), the relevant phases and practices emerge naturally during interactions. Therefore, I don't see a strong need to add a general-purpose claude.md to the RocksDB repository.

That's fair. I can remove the change in CLAUDE.md and keep the skill file. I do find it is quite useful. This way it does not diluting the context. While we could still add skills if folks prefer. Would that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants