add a claude skill for adding a new feature#14389
add a claude skill for adding a new feature#14389xingbowang wants to merge 1 commit intofacebook:mainfrom
Conversation
✅ clang-tidy: No findings on changed linesCompleted in 0.0s. |
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D94368806. |
hx235
left a comment
There was a problem hiding this comment.
I'm hesitant about incorporating broad, soft aspects of software engineering or general problem-solving guidance into a RocksDB project-specific claude.md. Doing so risks diluting the context, which should primarily serve to guide code generation toward the "right" approach—especially in areas not enforced by compilation. For example, see #14360 (comment).
Claude is rapidly evolving to behave more like a professional software engineer. I expect that much of the guidance currently written in the markdown file will soon be absorbed by the model itself.
In my experience, even without a standardized claude.md in the RocksDB repo (aside from custom versions I create as needed), the relevant phases and practices emerge naturally during interactions. Therefore, I don't see a strong need to add a general-purpose claude.md to the RocksDB repository.
That's fair. I can remove the change in CLAUDE.md and keep the skill file. I do find it is quite useful. This way it does not diluting the context. While we could still add skills if folks prefer. Would that work? |
93d9140 to
1340e24
Compare
Summary:
I have found this skill to be quite helpful for both adding a new feature or even asking questions about certain details. It is able to do a good job dive deep into component.
Usage: /add_feature
Test:
Local claude