Skip to content

Call stopTracking() on host component unmount to prevent input memory leak #36223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stewartmcgown wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

Call stopTracking() on host component unmount to prevent input memory leak #36223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd6fbd
Call stopTracking() on host component unmount to prevent input memory…
stewartmcgown Apr 6, 2026
9224c66
Merge branch 'main' into fix/stop-tracking-on-unmount
stewartmcgown Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-dom-bindings/src/client/ReactDOMComponentTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ import {enableScopeAPI} from 'shared/ReactFeatureFlags';

import {enableInternalInstanceMap} from 'shared/ReactFeatureFlags';

import {stopTracking} from './inputValueTracking';

const randomKey = Math.random().toString(36).slice(2);
const internalInstanceKey = '__reactFiber$' + randomKey;
const internalPropsKey = '__reactProps$' + randomKey;
Expand Down Expand Up @@ -68,6 +70,7 @@ const internalPropsMap:
| Map<InstanceUnion, Props> = new PossiblyWeakMap();

export function detachDeletedInstance(node: Instance): void {
stopTracking((node: any));
if (enableInternalInstanceMap) {
internalInstanceMap.delete(node);
internalPropsMap.delete(node);
Expand Down
Loading