Add transform-box SVG attribute alias and fix mask-type warning alias#36182
Add transform-box SVG attribute alias and fix mask-type warning alias#36182Zelys-DFKH wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @Zelys-DFKH! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
`transform-box` is a valid SVG presentation attribute that defines the reference box for `transform` and `transform-origin` (SVG 2, CSS Transforms Level 1). Without an alias, writing `transformBox="fill-box"` in JSX sets a literal `transformBox` attribute on the DOM element instead of the expected `transform-box`.
This also completes the support added in #35921. That PR added `masktype: 'maskType'` to `possibleStandardNames.js` but not the hyphenated companion `'mask-type': 'maskType'`. Every other hyphenated SVG attribute in that file has both entries (`flood-color`/`floodcolor`, `text-rendering`/`textrendering`, and so on). The missing entry means developers who pass `mask-type` via spread or `createElement` get no warning pointing them to `maskType`.
Changes:
`getAttributeAlias.js` adds `['transformBox', 'transform-box']` so React sets the correct DOM attribute name when `transformBox` is used as a JSX prop.
`possibleStandardNames.js` adds `'mask-type': 'maskType'` and the `transformbox`/`'transform-box'` entries so the "Did you mean?" warning fires for both attributes when the wrong form is used.
`ReactDOMComponent-test.js` adds tests covering the full init/update/null/undefined/removal cycle for `transformBox`, and SSR warning tests for both `mask-type` and `transform-box`.