Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a false positive in the react-hooks/refs ESLint rule triggered when multiple refs are stored in an object (e.g. const groupRefs = { group1: useRef(), group2: useRef() }) and passed to JSX (ref={groupRefs.group2}), which incorrectly reported “Cannot access ref value during render”.
Root cause: collectTemporariesSidemap aliased PropertyLoad results to the source object. As a result, env.set on a property-load lvalue resolved through temporaries and corrupted the object’s type (from Structure{Ref} to Ref), causing subsequent property loads to return RefValue instead of Ref.
Fix: remove PropertyLoad aliasing from collectTemporariesSidemap (the main validation already tracks types correctly) and update PropertyLoad handling in the main validator to propagate function type info from Structure types when the value is null.
Fixes #35813
Test plan