Enables Basic View Transition support for React Native Fabric renderer #35764
+288
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - turn on enableViewTransition feature - stub shim - run some mutation config fn at persistence mode too
Better reflects that this signals the transition has started rather than initiating it.
…enable startViewTransition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables Basic View Transition support for React Native Fabric renderer.
Implemented:
measureInstance,applyViewTransitionName,startViewTransition,restoreViewTransitionName, andcancelViewTransitionNamestartViewTransitionwith proper callback orchestration (mutation → layout → afterMutation → spawnedWork → passive)startViewTransitionreturns false (e.g., when the ViewTransition ReactNativeFeatureFlag is not enabled)Stubbed with
__DEV__warnings (not yet implemented):cancelRootViewTransitionNamerestoreRootViewTransitionNamecloneRootViewTransitionContainerremoveRootViewTransitionClonemeasureClonedInstancehasInstanceChangedhasInstanceAffectedParentstartGestureTransitionstopViewTransitiongetCurrentGestureOffsetThis allows React Native apps using Fabric to leverage the View Transition API for coordinated animations during state transitions, with graceful degradation when the native side doesn't support it.
Below are diagrams of proposed architecture in fabric, and observation of what/when config functions get called during a basic shared transition example
How did you test this change?
yarn flow fabric- Flow type checks passyarn lint- Lint checks passReactFeatureFlags.test-renderer.native-fb.jsand View Transition enabled via ReactNativeFeatureFlagReactFabric-dev.fb.jsthat the 'shim' config functions are not included__DEV__and flushes work synchronously when ViewTransition flag isn't enabled in Fabric