Skip to content

Replace use of private HostInstance types in Fantom tests #56947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 2 commits into from
+16 −20
Closed

Replace use of private HostInstance types in Fantom tests #56947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e859ab6
Remove unreferenced ViewNativeComponentType (#56943)
huntie May 22, 2026
60fe049
Replace use of private HostInstance types in Fantom tests
huntie May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions packages/react-native/Libraries/Components/TextInput/__tests__/TextInput-itest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';

import type {TextInputInstance} from '../TextInput.flow';

import * as Fantom from '@react-native/fantom';
import nullthrows from 'nullthrows';
import * as React from 'react';
Expand Down Expand Up @@ -45,7 +43,7 @@ describe('<TextInput>', () => {
describe('onChange', () => {
it('is called when the change native event is dispatched', () => {
const root = Fantom.createRoot();
const nodeRef = createRef<TextInputInstance>();
const nodeRef = createRef<React.ElementRef<typeof TextInput>>();
const onChange = jest.fn();

Fantom.runTask(() => {
Expand Down Expand Up @@ -76,7 +74,7 @@ describe('<TextInput>', () => {
describe('onChangeText', () => {
it('is called when the change native event is dispatched', () => {
const root = Fantom.createRoot();
const nodeRef = createRef<TextInputInstance>();
const nodeRef = createRef<React.ElementRef<typeof TextInput>>();
const onChangeText = jest.fn();

Fantom.runTask(() => {
Expand All @@ -100,7 +98,7 @@ describe('<TextInput>', () => {
describe('onFocus', () => {
it('is called when the focus native event is dispatched', () => {
const root = Fantom.createRoot();
const nodeRef = createRef<TextInputInstance>();
const nodeRef = createRef<React.ElementRef<typeof TextInput>>();

let focusEvent = jest.fn();

Expand All @@ -126,7 +124,7 @@ describe('<TextInput>', () => {
describe('onBlur', () => {
it('is called when the blur native event is dispatched', () => {
const root = Fantom.createRoot();
const nodeRef = createRef<TextInputInstance>();
const nodeRef = createRef<React.ElementRef<typeof TextInput>>();

let blurEvent = jest.fn();

Expand Down Expand Up @@ -284,7 +282,7 @@ describe('<TextInput>', () => {

describe('ref', () => {
it('is an element node', () => {
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

const root = Fantom.createRoot();

Expand All @@ -296,7 +294,7 @@ describe('<TextInput>', () => {
});

it('provides additional methods: clear, isFocused, getNativeRef, setSelection', () => {
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

const root = Fantom.createRoot();

Expand All @@ -313,7 +311,7 @@ describe('<TextInput>', () => {
describe('focus()', () => {
it('dispatches the focus command', () => {
const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(<TextInput nativeID="text-input" ref={ref} />);
Expand Down Expand Up @@ -411,8 +409,8 @@ describe('<TextInput>', () => {

it('unfocuses any previously focused TextInput when a new one is focused', () => {
const root = Fantom.createRoot();
const ref1 = createRef<TextInputInstance>();
const ref2 = createRef<TextInputInstance>();
const ref1 = createRef<React.ElementRef<typeof TextInput>>();
const ref2 = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(
Expand Down Expand Up @@ -450,7 +448,7 @@ describe('<TextInput>', () => {
describe('blur()', () => {
it('does NOT dispatch any commands if the input is NOT focused', () => {
const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(<TextInput nativeID="text-input" ref={ref} />);
Expand All @@ -469,7 +467,7 @@ describe('<TextInput>', () => {

it('does dispatches the blur command if the input is focused', () => {
const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(<TextInput nativeID="text-input" ref={ref} />);
Expand All @@ -496,7 +494,7 @@ describe('<TextInput>', () => {
describe('clear()', () => {
it('dispatches the clear command', () => {
const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(
Expand All @@ -521,7 +519,7 @@ describe('<TextInput>', () => {
describe('isFocused()', () => {
it('returns true if the input is focused', () => {
const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(<TextInput nativeID="text-input" ref={ref} />);
Expand All @@ -546,7 +544,7 @@ describe('<TextInput>', () => {

it('returns false if the input is unmounted', () => {
const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(<TextInput nativeID="text-input" ref={ref} />);
Expand Down Expand Up @@ -582,7 +580,7 @@ describe('<TextInput>', () => {
expect(TextInput.State.currentlyFocusedInput()).toBe(null);

const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(<TextInput nativeID="text-input" ref={ref} />);
Expand All @@ -606,7 +604,7 @@ describe('<TextInput>', () => {
describe('setSelection', () => {
it('dispatches the setTextAndSelection command', () => {
const root = Fantom.createRoot();
const ref = createRef<TextInputInstance>();
const ref = createRef<React.ElementRef<typeof TextInput>>();

Fantom.runTask(() => {
root.render(
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native/Libraries/Components/View/ViewNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,3 @@ export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
// Additional note: Our long term plan is to reduce the overhead of the <Text>
// and <View> wrappers so that we no longer have any reason to export these APIs.
export default ViewNativeComponent;

export type ViewNativeComponentType = HostComponent<Props>;
Loading