Remove legacy architecture stub UIImplementation (#56939)#56939
Open
cortinico wants to merge 1 commit into
Open
Remove legacy architecture stub UIImplementation (#56939)#56939cortinico wants to merge 1 commit into
UIImplementation (#56939)#56939cortinico wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106086358. |
Summary: This class was fully stubbed out as part of the Legacy Architecture removal. All public methods had empty bodies or returned null/0, meaning any OSS library still referencing it was already silently broken at runtime. Also removes the dead `getUIImplementation()` method from `UIManagerModule`, removes `enqueueLayoutUpdateFinished` from `UIViewOperationQueue`, and cleans up stale Javadoc references in `JSTouchDispatcher`, `ReactViewGroup`, and `ReactInterceptingViewGroup`. `UIBlock`, `NativeViewHierarchyManager`, `UIViewOperationQueue`, and the `addUIBlock`/`prependUIBlock` methods on `UIManagerModule` are retained and will be deprecated in a follow-up diff. Changelog: [Android][Removed] - Remove legacy architecture stub `UIImplementation`. This class was already non-functional (all methods were empty stubs). Reviewed By: javache Differential Revision: D106086358
meta-codesync
Bot
changed the title
UIImplementationUIImplementation (#56939)
cortinico
force-pushed
the
export-D106086358
branch
from
6513c32 to
9c7b241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This class was fully stubbed out as part of the Legacy Architecture removal. All public methods had empty bodies or returned null/0, meaning any OSS library still referencing it was already silently broken at runtime.
Also removes the dead
getUIImplementation()method fromUIManagerModule, removesenqueueLayoutUpdateFinishedfromUIViewOperationQueue, and cleans up stale Javadoc references inJSTouchDispatcher,ReactViewGroup, andReactInterceptingViewGroup.UIBlock,NativeViewHierarchyManager,UIViewOperationQueue, and theaddUIBlock/prependUIBlockmethods onUIManagerModuleare retained and will be deprecated in a follow-up diff.Changelog:
[Android][Removed] - Remove legacy architecture stub
UIImplementation. This class was already non-functional (all methods were empty stubs).Reviewed By: javache
Differential Revision: D106086358