Skip to content

Use dispatch_semaphore for eager-main-queue module setup gate #56932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javache wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −8
Open

Use dispatch_semaphore for eager-main-queue module setup gate #56932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,13 +379,10 @@ - (void)_start
*/
NSArray<NSString *> *modulesRequiringMainQueueSetup = [_delegate unstableModulesRequiringMainQueueSetup];

std::shared_ptr<std::mutex> mutex = std::make_shared<std::mutex>();
std::shared_ptr<std::condition_variable> cv = std::make_shared<std::condition_variable>();
std::shared_ptr<bool> isReady = std::make_shared<bool>(false);
dispatch_semaphore_t moduleSetupComplete = dispatch_semaphore_create(0);

_waitUntilModuleSetupComplete = ^{
std::unique_lock<std::mutex> lock(*mutex);
cv->wait(lock, [isReady] { return *isReady; });
dispatch_semaphore_wait(moduleSetupComplete, DISPATCH_TIME_FOREVER);
};

// TODO(T218039767): Integrate perf logging into main queue module init
Expand All @@ -398,9 +395,7 @@ - (void)_start
RCTScreenScale();
RCTSwitchSize();

std::lock_guard<std::mutex> lock(*mutex);
*isReady = true;
cv->notify_all();
dispatch_semaphore_signal(moduleSetupComplete);
});
}

Expand Down
Loading