Skip to content

Allow RCTScrollViewComponentView to be subclass-able #56319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joevilches wants to merge 1 commit into
base: main
Choose a base branch
from
+69 −3
Open

Allow RCTScrollViewComponentView to be subclass-able #56319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ NS_ASSUME_NONNULL_BEGIN
/*
* Returns an actual UIScrollView that this component uses under the hood.
*/
@property (nonatomic, strong, readonly) UIScrollView *scrollView;
@property (nonatomic, strong, readwrite) UIScrollView *scrollView;

/** Focus area of newly-activated text input relative to the window to compare against UIKeyboardFrameBegin/End */
@property (nonatomic, assign) CGRect firstResponderFocus;
Expand Down
13 changes: 13 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3871,6 +3871,11 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}
Expand Down Expand Up @@ -5657,6 +5662,7 @@ enum facebook::react::BlendMode {
Multiply,
Normal,
Overlay,
PlusLighter,
Saturation,
Screen,
SoftLight,
Expand Down Expand Up @@ -8920,6 +8926,12 @@ class facebook::react::NativeVibrationCxxSpec : public facebook::react::TurboMod
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeViewTransitionCxxSpec : public facebook::react::TurboModule {
protected NativeViewTransitionCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeWebSocketModuleCxxSpec : public facebook::react::TurboModule {
protected NativeWebSocketModuleCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
Expand Down Expand Up @@ -10673,6 +10685,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
public void notifyFastRefreshComplete();
public ~RuntimeAgent();
}

Expand Down
13 changes: 13 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3868,6 +3868,11 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}
Expand Down Expand Up @@ -5648,6 +5653,7 @@ enum facebook::react::BlendMode {
Multiply,
Normal,
Overlay,
PlusLighter,
Saturation,
Screen,
SoftLight,
Expand Down Expand Up @@ -8911,6 +8917,12 @@ class facebook::react::NativeVibrationCxxSpec : public facebook::react::TurboMod
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeViewTransitionCxxSpec : public facebook::react::TurboModule {
protected NativeViewTransitionCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeWebSocketModuleCxxSpec : public facebook::react::TurboModule {
protected NativeWebSocketModuleCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
Expand Down Expand Up @@ -10529,6 +10541,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
public void notifyFastRefreshComplete();
public ~RuntimeAgent();
}

Expand Down
15 changes: 14 additions & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,8 +1987,8 @@ interface RCTScrollView : public RCTView <UIScrollViewDelegate, RCTScrollablePro
interface RCTScrollViewComponentView {
protected __pad0__;
public @property (assign) CGRect firstResponderFocus;
public @property (strong) UIScrollView* scrollView;
public @property (strong, readonly) RCTGenericDelegateSplitter<id<UIScrollViewDelegate>>* scrollViewDelegateSplitter;
public @property (strong, readonly) UIScrollView* scrollView;
public @property (strong, readonly) UIView* containerView;
public @property (weak) UIView* firstResponderViewOutsideScrollView;
public virtual static _Nullable RCTScrollViewComponentView* findScrollViewComponentViewForView:(UIView* view);
Expand Down Expand Up @@ -6469,6 +6469,11 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down Expand Up @@ -8262,6 +8267,7 @@ enum facebook::react::BlendMode {
Multiply,
Normal,
Overlay,
PlusLighter,
Saturation,
Screen,
SoftLight,
Expand Down Expand Up @@ -11295,6 +11301,12 @@ class facebook::react::NativeVibrationCxxSpec : public facebook::react::TurboMod
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeViewTransitionCxxSpec : public facebook::react::TurboModule {
protected NativeViewTransitionCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeWebSocketModuleCxxSpec : public facebook::react::TurboModule {
protected NativeWebSocketModuleCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
Expand Down Expand Up @@ -12964,6 +12976,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
public void notifyFastRefreshComplete();
public ~RuntimeAgent();
}

Expand Down
15 changes: 14 additions & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,8 +1987,8 @@ interface RCTScrollView : public RCTView <UIScrollViewDelegate, RCTScrollablePro
interface RCTScrollViewComponentView {
protected __pad0__;
public @property (assign) CGRect firstResponderFocus;
public @property (strong) UIScrollView* scrollView;
public @property (strong, readonly) RCTGenericDelegateSplitter<id<UIScrollViewDelegate>>* scrollViewDelegateSplitter;
public @property (strong, readonly) UIScrollView* scrollView;
public @property (strong, readonly) UIView* containerView;
public @property (weak) UIView* firstResponderViewOutsideScrollView;
public virtual static _Nullable RCTScrollViewComponentView* findScrollViewComponentViewForView:(UIView* view);
Expand Down Expand Up @@ -6466,6 +6466,11 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down Expand Up @@ -8253,6 +8258,7 @@ enum facebook::react::BlendMode {
Multiply,
Normal,
Overlay,
PlusLighter,
Saturation,
Screen,
SoftLight,
Expand Down Expand Up @@ -11286,6 +11292,12 @@ class facebook::react::NativeVibrationCxxSpec : public facebook::react::TurboMod
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeViewTransitionCxxSpec : public facebook::react::TurboModule {
protected NativeViewTransitionCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public static constexpr std::string_view kModuleName;
}

template <typename T>
class facebook::react::NativeWebSocketModuleCxxSpec : public facebook::react::TurboModule {
protected NativeWebSocketModuleCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
Expand Down Expand Up @@ -12830,6 +12842,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
public void notifyFastRefreshComplete();
public ~RuntimeAgent();
}

Expand Down
7 changes: 7 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2519,6 +2519,11 @@ class facebook::react::NativeToJsBridge {
public void* getJavaScriptContext();
}

class facebook::react::NativeViewTransition : public NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
}

class facebook::react::NetworkReporter {
public bool isDebuggingEnabled() const;
public static facebook::react::NetworkReporter& getInstance();
Expand Down Expand Up @@ -4053,6 +4058,7 @@ enum facebook::react::BlendMode {
Multiply,
Normal,
Overlay,
PlusLighter,
Saturation,
Screen,
SoftLight,
Expand Down Expand Up @@ -7744,6 +7750,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
public void notifyFastRefreshComplete();
public ~RuntimeAgent();
}

Expand Down
7 changes: 7 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2516,6 +2516,11 @@ class facebook::react::NativeToJsBridge {
public void* getJavaScriptContext();
}

class facebook::react::NativeViewTransition : public NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
}

class facebook::react::NetworkReporter {
public bool isDebuggingEnabled() const;
public static facebook::react::NetworkReporter& getInstance();
Expand Down Expand Up @@ -4044,6 +4049,7 @@ enum facebook::react::BlendMode {
Multiply,
Normal,
Overlay,
PlusLighter,
Saturation,
Screen,
SoftLight,
Expand Down Expand Up @@ -7735,6 +7741,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
public void notifyFastRefreshComplete();
public ~RuntimeAgent();
}

Expand Down
Loading