PreparedLayoutTextView: Don't show a selection highlight when tapping on links (all pressable text)#55633
Open
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Open
PreparedLayoutTextView: Don't show a selection highlight when tapping on links (all pressable text)#55633NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
… on links (all pressable text) Summary: With [origins](https://github.com/facebook/litho/blob/55e28e58930a53133620fd32406ec8c3a9116c0c/litho-rendercore-text/src/main/java/com/facebook/rendercore/text/RCTextView.java#L525) in Litho's RCTextView, tapping a link in a PreparedLayoutTextView will select the link (as if keyboarding to it), before activating click, then clearing selection. D86657563 made all pressable text links, so now we show a new selection highlight in a lot of places. That's a visual difference compared to before, that I am concerned might be breaking. Let's remove it. Changelog: [Internal] Differential Revision: D93820112
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93820112. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With origins in Litho's RCTextView, tapping a link in a PreparedLayoutTextView will select the link (as if keyboarding to it), before activating click, then clearing selection.
D86657563 made all pressable text links, so now we show a new selection highlight in a lot of places.
That's a visual difference compared to before, that I am concerned might be breaking. Let's remove it.
Changelog: [Internal]
Differential Revision: D93820112