Enable defaultTextToOverflowHidden by default#55632
Open
NickGerleman wants to merge 2 commits intofacebook:mainfrom
Open
Enable defaultTextToOverflowHidden by default#55632NickGerleman wants to merge 2 commits intofacebook:mainfrom
NickGerleman wants to merge 2 commits intofacebook:mainfrom
Conversation
…visible text with props 2.0) (facebook#55553) Summary: RN components on the native side currently act like a mix of both overflow: hidden and overflow: visible, veering closer to the former in the ways that matter most. PreparedLayoutTextView lets us implement this more correctly, and either clip text to padding box, or not clip the text at all. For compat, PreparedLayoutTextView/PreparedLayoutTextViewManager defaulted to `overflow: hidden`. Props 2.0, broke this, since we need to see overflow state change in Fabric props, which defaults to Yoga blank style defaults (always `overflow: visible`). The sanest solution I could find was to change Android native view to keep same defaults as Fabric style layer, then explicitly set `overflow: hidden` at the style layer, as the default behavior. This does slightly change behavior, so that components which previously clipped at the bounding rect of their border box, now clip at their padding box. I.e. text will not be drawn over borders, or rounded corners, by default after this change. Changelog: [General][Changed] - Text is no longer drawn on top of borders by default [General][Changed] - Text outside the bounds of a borderRadius is now hidden by default Reviewed By: mdvacca Differential Revision: D93324626
Summary: Talking to mdvacca, we think this change should be pretty safe, so turning on by default. Changelog entry in last change. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93796779
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93796779. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Talking to mdvacca, we think this change should be pretty safe, so turning on by default. Changelog entry in last change.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D93796779