Update eslint-plugin-ft-flow to fix ESLint v9 issue#55628
Open
tcK1 wants to merge 1 commit intofacebook:mainfrom
Open
Update eslint-plugin-ft-flow to fix ESLint v9 issue#55628tcK1 wants to merge 1 commit intofacebook:mainfrom
eslint-plugin-ft-flow to fix ESLint v9 issue#55628tcK1 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When trying to use the
@react-native/eslint-configwith ESLint v9, we get an issue with theeslint-plugin-ft-flow:Looking into it, I noticed that our current version (
^2.0.0) does not support ESLint v9. Only in version^3.0.11it show as a valid peer dependency version.So, although we do have a flat config, we don't support ESLint v9 out of the box.
Changelog:
[General] [Fixed] - Fixed the issue when using the flat config with ESLint v9.
Test Plan:
I've made a repro repo: https://github.com/tcK1/Repro-ESLint9-RN
Updated the ESLint version to v9 and added the
eslint-plugin-ft-flowversion in theresolutionsconfiguration in thepackage.json.In this state, running
yarn eslint .works as expected. To reproduce the issue, remove theresolutionsfield and run the command again.