Skip to content

Update eslint-plugin-ft-flow to fix ESLint v9 issue#55628

Open
tcK1 wants to merge 1 commit intofacebook:mainfrom
tcK1:update-eslint-plugin-ft-flow
Open

Update eslint-plugin-ft-flow to fix ESLint v9 issue#55628
tcK1 wants to merge 1 commit intofacebook:mainfrom
tcK1:update-eslint-plugin-ft-flow

Conversation

@tcK1
Copy link

@tcK1 tcK1 commented Feb 19, 2026

Summary:

When trying to use the @react-native/eslint-config with ESLint v9, we get an issue with the eslint-plugin-ft-flow:

Oops! Something went wrong! :(

ESLint: 9.39.2

TypeError: Error while loading rule 'ft-flow/define-flow-type': context.getAllComments is not a function

Looking into it, I noticed that our current version (^2.0.0) does not support ESLint v9. Only in version ^3.0.11 it show as a valid peer dependency version.

So, although we do have a flat config, we don't support ESLint v9 out of the box.

Changelog:

[General] [Fixed] - Fixed the issue when using the flat config with ESLint v9.

Test Plan:

I've made a repro repo: https://github.com/tcK1/Repro-ESLint9-RN

Updated the ESLint version to v9 and added the eslint-plugin-ft-flow version in the resolutions configuration in the package.json.

In this state, running yarn eslint . works as expected. To reproduce the issue, remove the resolutions field and run the command again.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2026
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments