Show type alias name in union member errors#55604
Open
elicwhite wants to merge 2 commits intofacebook:mainfrom
Open
Show type alias name in union member errors#55604elicwhite wants to merge 2 commits intofacebook:mainfrom
elicwhite wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@elicwhite has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93262589. |
Summary: TypeAliasTypeAnnotation members in unions were all treated as equal (returning 0) by the sort comparator, which meant the merge-based comparison in compareUnionMemberArrays could not distinguish between different type aliases like ObjectA, ObjectB, and ObjectC. This caused it to compare them positionally instead of by identity, misreporting added/removed union members as type mismatches. The fix compares TypeAliasTypeAnnotation by name, similar to how StringLiteralTypeAnnotation compares by value, allowing the merge algorithm to correctly identify which members were added or removed. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D93262588
Summary: When reporting added/removed union members of type TypeAliasTypeAnnotation, the error message showed the generic type kind "TypeAliasTypeAnnotation" instead of the actual alias name (e.g., "ObjectC"). This adds a case to getTypeAnnotationLabel to return the alias name for TypeAliasTypeAnnotation, producing clearer error messages like "Member ObjectC" instead of "Member TypeAliasTypeAnnotation". Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D93262589
elicwhite
force-pushed
the
export-D93262589
branch
from
e0d1ca5 to
c0abd2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When reporting added/removed union members of type TypeAliasTypeAnnotation, the error message showed the generic type kind "TypeAliasTypeAnnotation" instead of the actual alias name (e.g., "ObjectC"). This adds a case to getTypeAnnotationLabel to return the alias name for TypeAliasTypeAnnotation, producing clearer error messages like "Member ObjectC" instead of "Member TypeAliasTypeAnnotation".
Changelog: [Internal]
Differential Revision: D93262589