Add failing tests for union object type addition#55602
Open
elicwhite wants to merge 1 commit intofacebook:mainfrom
Open
Add failing tests for union object type addition#55602elicwhite wants to merge 1 commit intofacebook:mainfrom
elicwhite wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: The compat check v2 does not correctly detect when a new object type is added to a union used in a function parameter flowing to native. This adds test fixtures and test cases that reproduce this bug: adding ObjectC to an ObjectA | ObjectB union should be flagged as incompatible (native won't expect the new type), and removing ObjectC should be flagged as ok (native can handle fewer types). Currently the tests fail because the sorting logic treats all TypeAliasTypeAnnotation members as equal, causing the merge-comparison to misidentify added/removed members as type mismatches. Changelog: [Internal] Differential Revision: D93262587
meta-cla
bot
added
the
CLA Signed
|
@elicwhite has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93262587. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The compat check v2 does not correctly detect when a new object type is added to a union used in a function parameter flowing to native. This adds test fixtures and test cases that reproduce this bug: adding ObjectC to an ObjectA | ObjectB union should be flagged as incompatible (native won't expect the new type), and removing ObjectC should be flagged as ok (native can handle fewer types). Currently the tests fail because the sorting logic treats all TypeAliasTypeAnnotation members as equal, causing the merge-comparison to misidentify added/removed members as type mismatches.
Changelog: [Internal]
Differential Revision: D93262587