Refactor: Rename installJSIBindings #54975
Closed
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
RSNara
force-pushed
the
export-D89709221
branch
3 times, most recently
from
ad21fc6 to
2cdaddf
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 24, 2025
Summary: I think dispatchJSBindingInstall is a more apt name. This will help align ios and android. On ios, installJSBindings is a function that executes on the js thread, with a runtime pointer. Changelog: [Internal] Differential Revision: D89709221
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2025
Summary: I think dispatchJSBindingInstall is a more apt name. This will help align ios and android. On ios, installJSBindings is a function that executes on the js thread, with a runtime pointer. Changelog: [Internal] Differential Revision: D89709221
RSNara
force-pushed
the
export-D89709221
branch
2 times, most recently
from
d987853 to
f6eaf56
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2025
Summary: I think dispatchJSBindingInstall is a more apt name. This will help align ios and android. On ios, installJSBindings is a function that executes on the js thread, with a runtime pointer. Changelog: [Internal] Differential Revision: D89709221
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 28, 2025
Summary: I think dispatchJSBindingInstall is a more apt name. This will help align ios and android. On ios, installJSBindings is a function that executes on the js thread, with a runtime pointer. Changelog: [Internal] Differential Revision: D89709221
RSNara
force-pushed
the
export-D89709221
branch
2 times, most recently
from
4b9022a to
60846e7
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 29, 2025
Summary: I think dispatchJSBindingInstall is a more apt name. This will help align ios and android. On ios, installJSBindings is a function that executes on the js thread, with a runtime pointer. Changelog: [Internal] Differential Revision: D89709221
cortinico
requested changes
Dec 29, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: I think dispatchJSBindingInstall is a more apt name. This will help align ios and android. On ios, installJSBindings is a function that executes on the js thread, with a runtime pointer. Changelog: [Internal] Reviewed By: javache Differential Revision: D89709221
RSNara
force-pushed
the
export-D89709221
branch
from
60846e7 to
2a28d46
Compare
|
This pull request has been merged in 663a9c1. |
Collaborator
|
This pull request was successfully merged by @RSNara in 663a9c1 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I think dispatchJSBindingInstall is a more apt name.
This will help align ios and android. On ios, installJSBindings is a function that executes on the js thread, with a runtime pointer.
Changelog: [Internal]
Differential Revision: D89709221