check non-callable bool in assert statements#3050

Open

knQzx wants to merge 1 commit intofacebook:mainfrom

knQzx:fix-assert-bool-check

Contributor

knQzx commented Apr 7, 2026

summary

assert statements now check that bool is callable on the test expression
previously only if/while/ternary checked this, assert was missing the check
matches behavior of pyright and mypy which flag this

test plan

updated existing bug test case to expect the error
all 4678 tests pass

fixes #2914


          check non-callable __bool__ in assert statements

b9a2e68

meta-cla bot added the cla signed label

github-actions bot added the size/xs label

github-actions bot commented Apr 7, 2026

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

github-actions bot added the needs-triage label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed needs-triage size/xs