fix(theme-classic): prevent Firefox clipping sidebar label descenders#12300
fix(theme-classic): prevent Firefox clipping sidebar label descenders#12300xusnitdinov wants to merge 1 commit into
Conversation
Add 1px bottom padding to line-clamped sidebar link/category labels so glyph descenders render correctly in Firefox on Windows. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @xusnitdinov! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Pre-flight checklist
Motivation
Fixes Firefox-on-Windows clipping of glyph descenders (
g,p,q,y) in documentation sidebar link and category labels.Those labels use
line-clamp: 2withoverflow: hiddenand Infima'sline-height: 1.25. Firefox paints the-webkit-boxclip boundary differently from Chromium, so descenders get cut off. Chromium and Firefox-on-macOS are fine.Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Affected styles:
packages/docusaurus-theme-classic/src/theme/DocSidebarItem/Link/styles.module.csspackages/docusaurus-theme-classic/src/theme/DocSidebarItem/Category/styles.module.cssRelated issues/PRs
Closes #12299