Skip to content

[Repo Assist] [TypeScript] Fix static class members not re-declaring class-level type parameters (fixes #3504) #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Draft

[Repo Assist] [TypeScript] Fix static class members not re-declaring class-level type parameters (fixes #3504) #4533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Fable.Cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

* [TypeScript] Fix static class members not re-declaring class-level type parameters, causing TypeScript type errors (fixes #3504)
* [JS/TS/Python/Beam] Fix `ResizeArray` (`System.Collections.Generic.List`) equality to use reference equality instead of structural equality (fixes #3718)
* [Beam] Fix `List.Cons` call replacement and test (by @ncave)
* [Beam/Dart/Python/TypeScript] Fix `Array.Equals` to use reference equality instead of structural equality (by @ncave)
Expand Down
1 change: 1 addition & 0 deletions src/Fable.Compiler/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

* [TypeScript] Fix static class members not re-declaring class-level type parameters, causing TypeScript type errors (fixes #3504)
* [JS/TS/Python/Beam] Fix `ResizeArray` (`System.Collections.Generic.List`) equality to use reference equality instead of structural equality (fixes #3718)
* [Beam] Fix `List.Cons` call replacement and test (by @ncave)
* [Beam/Dart/Python/TypeScript] Fix `Array.Equals` to use reference equality instead of structural equality (by @ncave)
Expand Down
9 changes: 8 additions & 1 deletion src/Fable.Transforms/Fable2Babel.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,7 +1404,14 @@ module Util =

let declaredTypeParams =
if isAttached then
info.GenericParameters
match kind with
| Attached(isStatic = true) ->
// Static methods cannot access class type params implicitly;
// they must re-declare them on the method itself.
entGenParams @ info.GenericParameters
| _ ->
// Instance methods inherit class type params; don't re-declare them.
info.GenericParameters
else
entGenParams @ info.GenericParameters
|> List.map (fun g -> Fable.GenericParam(g.Name, g.IsMeasure, g.Constraints))
Expand Down