Preserve wrapper identity during in-place dictionary union - #598
Open
Gonghan-Princess wants to merge 1 commit into
Open
Preserve wrapper identity during in-place dictionary union#598Gonghan-Princess wants to merge 1 commit into
Gonghan-Princess wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
After
b = benedict(source); b |= other,bcurrently becomes the underlying plaindict. Keypath access and the original wrapper identity are lost even though the source dictionary is updated correctly. For example, a wrapper configured withkeypath_separator="/"can no longer resolveb["item/name"]after the union.Keep the existing in-place update of the wrapped dictionary and return the wrapper itself. Add regressions for dictionary and key/value iterable inputs, both storage modes, source updates, and retained keypath configuration.
Related issue
Follow-up to #334: value updates were fixed there; this addresses the remaining loss of wrapper identity. All-state searches found no existing PR for that behavior.
Validation
Checklist before requesting a review
AI disclosure: OpenAI Codex investigated the bug, prepared the patch and tests, reviewed the diff, ran verification, and drafted this description. No third-party implementation was copied.