Skip to content

[patch] add name to containers #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faangbait merged 1 commit into from
Jun 2, 2026
Merged

[patch] add name to containers #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions group_vars/all.example.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ devcontainer_defaults:
- source=codex_config,target=/home/vscode/.codex,type=volume

devcontainers:
- path: java-example/.devcontainer/devcontainer.json
- name: java-example
path: java-example/.devcontainer/devcontainer.json
image: mcr.microsoft.com/devcontainers/java:3-25-trixie
features:
ghcr.io/devcontainers/features/java:1:
Expand All @@ -31,12 +32,14 @@ devcontainers:
installGradle: false
install: |
curl -sL -o cfr.jar 'https://www.benf.org/other/cfr/cfr-0.152.jar'
- path: rust-example/.devcontainer/devcontainer.json
- name: rust-example
path: rust-example/.devcontainer/devcontainer.json
image: mcr.microsoft.com/devcontainers/rust:2-1-trixie
install: |
sudo apt update
sudo -n apt-get install -y --no-install-recommends default-jre-headless
- path: python-example/.devcontainer/devcontainer.json
- name: python-example
path: python-example/.devcontainer/devcontainer.json
image: mcr.microsoft.com/devcontainers/python:3.14
post_attach_command: pip install -r ${containerWorkspaceFolder}/requirements.txt
features:
Expand Down
6 changes: 3 additions & 3 deletions tests/golden_output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"source=claude_config,target=/home/vscode/.claude,type=volume",
"source=codex_config,target=/home/vscode/.codex,type=volume"
],
"name": "devcontainer.json",
"name": "java-example",
"postCreateCommand": "bash .devcontainer/install.sh",
"postStartCommand": "sudo chown -R vscode:vscode /home/vscode/.claude*"
}
Expand Down Expand Up @@ -68,7 +68,7 @@ curl -sL -o cfr.jar 'https://www.benf.org/other/cfr/cfr-0.152.jar'
"source=claude_config,target=/home/vscode/.claude,type=volume",
"source=codex_config,target=/home/vscode/.codex,type=volume"
],
"name": "devcontainer.json",
"name": "python-example",
"postAttachCommand": "pip install -r ${containerWorkspaceFolder}/requirements.txt",
"postCreateCommand": "bash .devcontainer/install.sh",
"postStartCommand": "sudo chown -R vscode:vscode /home/vscode/.claude*"
Expand All @@ -92,7 +92,7 @@ sudo apt install -y --no-install-recommends ansible
"source=claude_config,target=/home/vscode/.claude,type=volume",
"source=codex_config,target=/home/vscode/.codex,type=volume"
],
"name": "devcontainer.json",
"name": "rust-example",
"postCreateCommand": "bash .devcontainer/install.sh",
"postStartCommand": "sudo chown -R vscode:vscode /home/vscode/.claude*"
}
Expand Down
2 changes: 1 addition & 1 deletion tests/java-example/.devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"source=claude_config,target=/home/vscode/.claude,type=volume",
"source=codex_config,target=/home/vscode/.codex,type=volume"
],
"name": "devcontainer.json",
"name": "java-example",
"postCreateCommand": "bash .devcontainer/install.sh",
"postStartCommand": "sudo chown -R vscode:vscode /home/vscode/.claude*"
}
2 changes: 1 addition & 1 deletion tests/python-example/.devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"source=claude_config,target=/home/vscode/.claude,type=volume",
"source=codex_config,target=/home/vscode/.codex,type=volume"
],
"name": "devcontainer.json",
"name": "python-example",
"postAttachCommand": "pip install -r ${containerWorkspaceFolder}/requirements.txt",
"postCreateCommand": "bash .devcontainer/install.sh",
"postStartCommand": "sudo chown -R vscode:vscode /home/vscode/.claude*"
Expand Down
2 changes: 1 addition & 1 deletion tests/rust-example/.devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"source=claude_config,target=/home/vscode/.claude,type=volume",
"source=codex_config,target=/home/vscode/.codex,type=volume"
],
"name": "devcontainer.json",
"name": "rust-example",
"postCreateCommand": "bash .devcontainer/install.sh",
"postStartCommand": "sudo chown -R vscode:vscode /home/vscode/.claude*"
}