Open
Conversation
Author
|
ping @f3lang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preventing me from building on macOS 10.14.4, because it overwrites any other PKG_CONFIG_PATH that I have set in my environment.
On my system, which I've set up using what I believe to be just standard Homebrew, I don't need to have
/opt/X11/lib/pkgconfigin my pkg config path. I do however need to have/usr/local/opt/libffi/lib/pkgconfigin there, which I had but it was overwritten by the removed lines.I'm not sure why this line was added in the beginning (it was a long time ago in a fork), but I think that it's up to the end user to have a correctly configured pkg config installation. Trying to fix end user configuration errors is error-prone and can easily lead to more errors (as seen here☺️ )...