Skip to content

Fix Chinese IME marked text handling#53

Open
Pluviobyte wants to merge 1 commit into
f:masterfrom
Pluviobyte:fix-ime-marked-text
Open

Fix Chinese IME marked text handling#53
Pluviobyte wants to merge 1 commit into
f:masterfrom
Pluviobyte:fix-ime-marked-text

Conversation

@Pluviobyte
Copy link
Copy Markdown

Summary

  • skip SwiftUI/AppKit text synchronization while the editor has marked text from an input method
  • avoid reapplying highlighting or restoring selection during IME composition
  • allow Chinese IME pre-edit text and candidate selection to complete before updating the bound script text

Fixes #34.

Validation

  • Manually verified on macOS with Sogou Pinyin: typed nihao and committed it as 你好 in the Textream editor
  • Manually verified composition stays visible before committing ceshi to 测试
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot input Chinese

1 participant