Open
Conversation
Owner
|
Sorry to let this sit so long. I appreciate it. I tested this locally, and there's another issue, which is my fault: There are two ways to serialize the resulting post to a dictionary, and they give different results. ---
content: bad key
---
Ooops!>>> import frontmatter
>>> p = frontmatter.load('oops.md')
>>> p.content
'Ooops!'
>>> dict(p)
{'content': 'bad key'}
>>> p['content']
'bad key
>>> p.metadata
{'content': 'bad key'}
>>> p.to_dict()
{'content': 'Ooops!'}So that's a problem, and it needs a decision more than a technical solution. No matter what, it's going to be a breaking change somewhere. |
Author
|
I understand, but do you plan to release a new major version then? It seems that in the end, making new major with instruction how to migrate will be beneficial for many ppl anyway. I see that many forks are created just to add that fix. |
Owner
|
I will push a new release soon, just haven't had time yet with work stuff. I need to decide on this one and pull together any other breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96