Repository navigation
fix: ignore environment-specific dotenv files - #383
Open
vibhor-aggr wants to merge 1 commit into
Open
vibhor-aggr wants to merge 1 commit into
vibhor-aggr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381.
The generated
.gitignorenow ignores environment-specific dotenv files with.env.*, while!.env.examplekeeps the example file trackable. This changes only the JavaScript gitignore template and adds a regression for generated--gitoutput.Verification on Node 24.16.0:
./node_modules/.bin/mocha --reporter spec --check-leaks test/ --grep=--git: 5 passed.--grep 'npm start|should have installable dependencies|should export an express app from app.js' --invert.git check-ignore --no-indexsmoke check confirms.env,.env.local,.env.development,.env.production,.env.test, and.env.production.localare ignored at root and underconfig/;.env.example,.environment, andREADME.mdare not ignored in either location. Generation without--gitstill does not create a.gitignore.npm run lintandgit diff --check: passed.The generated-app dependency installation/runtime tests were not rerun. The existing Sass fixture depends on the legacy node-sass/Python-2 toolchain and is incompatible with this local Node 24 environment; this change does not modify application dependencies.