Conversation
Author
|
The CI failure is because |
simonwilson4moj
added a commit
to ministryofjustice/hmpps-community-accommodation-tier-2-ui
that referenced
this pull request
Sep 16, 2026
# Context https://dsdmoj.atlassian.net/browse/SAS-1129 ### proxy-addr@2.0.7 https://github.com/ministryofjustice/hmpps-community-accommodation-tier-2-ui/security/code-scanning/178 Cannot fix this due to express not having the update yet, they will do so in around 7 days - expressjs/express#7474 So we can fix this right now by overriding the value first, then after 7 days updating express once they've got the update. ### undici@6.26.0 https://github.com/ministryofjustice/hmpps-community-accommodation-tier-2-ui/security/code-scanning/134 To fix undici I had to bump @types/node up a major version. After trying to run the build it failed for 1 place. I tried a few different fixes like bumping typescript or bumping the ts.config target version to 2022/24. but this creates more issues. So i resolved the one issue instead, next bump will likely require the rest of the typescript fixes.
bjohansebas
approved these changes
Sep 16, 2026
UlisesGascon
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
proxy-addrto^2.0.8to resolve CVE-2026-90711.Fixes #7473