guard map key type before MapIndex in get#967
Open
netliomax25-code wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get builtin documents that it returns nil instead of panicking, but the map branch calls v.MapIndex(reflect.ValueOf(i)) directly. When the key is not assignable to the map's key type, or is an unhashable value reaching a map[any]any, reflect panics and the vm surfaces a raw reflect message like "reflect.Value.MapIndex: value of type ... is not assignable". Reachable from a dynamically typed map, e.g. get(m, [1,2]) where m has static type any. Check the key against the map key type and comparability first and fall back to nil, matching how missing keys already behave.