Open
Conversation
|
Subscribed to pull request
Generated by CodeMention |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3549 +/- ##
==========================================
- Coverage 53.85% 53.80% -0.05%
==========================================
Files 819 820 +1
Lines 34889 34978 +89
Branches 7205 7280 +75
==========================================
+ Hits 18786 18815 +29
- Misses 16012 16072 +60
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
sjchmiela
approved these changes
Mar 27, 2026
| ); | ||
| const repackApp = await installAndImportRepackAsync({ | ||
| packageName: inputs.repack_package.value as string, | ||
| version: inputs.repack_version.value as string, |
Contributor
There was a problem hiding this comment.
Let's then use resolvedRepackVersion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
nice to have feature requested by customers
How
showing the resolved repack version in build log, e.g.
Using repack from: @expo/repack@latest (1.2.3)Test Plan
add unit test for the
resolvePackageVersionAsync