Remove local project generation from go command#3514
Open
Conversation
The `go` command previously created a full local project in /tmp (app.json, eas.json, package.json, npm install, git init) to satisfy credentials setup and workflow upload. This was unnecessary because: - Credential setup (SetUpBuildCredentials, SetUpAscApiKey, SetUpPushKey) operates entirely through GraphQL/Apple APIs and never reads from disk - CredentialsContext only needs an in-memory ExpoConfig and projectId - The workflow can generate its own project independently Now the command: - Constructs ExpoConfig in-memory instead of writing/reading app.json - Passes a no-op VcsClient since credential actions don't use it - No longer runs npm install or git init - Creates minimal temp files only for the workflow upload tarball - No longer changes process.cwd() or preserves/cleans up project dirs
|
Subscribed to pull request
Generated by CodeMention |
SetUpBuildCredentials can trigger interactive prompts (e.g. certificate revocation selection when Apple's cert limit is hit). Wrapping it in withSuppressedOutputAsync hid these prompts, causing an invisible prompt that led to an infinite retry loop.
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3514 +/- ##
==========================================
+ Coverage 53.56% 53.65% +0.09%
==========================================
Files 815 815
Lines 34566 34616 +50
Branches 7175 7193 +18
==========================================
+ Hits 18513 18570 +57
+ Misses 15971 15965 -6
+ Partials 82 81 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
gocommand creates a full local project in/tmp(writesapp.json,eas.json,package.json, runsnpm install,git init,git commit) solely to satisfy the credentials setup and produce files for the workflow upload. This is unnecessary overhead — credentials operate entirely through remote APIs and the workflow can generate its own project.This is a step toward having the workflow create its own project server-side, removing the dependency on user-uploaded project files.
How
expobject directly instead of writingapp.jsonto disk and reading it back withgetPrivateExpoConfigAsyncNoVcsClienttoCredentialsContextsince none of the iOS credential actions (SetUpBuildCredentials,SetUpAscApiKey,SetUpPushKey) use itnode_modulesor a git repotar.create()on a minimal temp directory instead of going through VCS-baseduploadAccountScopedProjectSourceAsyncprocess.chdir(projectDir)/ restore pattern entirelysaveProjectIdToAppConfigAsync: Project ID is kept in-memory, no need to write it to diskascAppId, package.json, app.json) right before upload, then cleans up immediatelyTest Plan
yarn tsc --noEmitpasses forgo.ts(confirmed: no type errors)yarn lintpasses (confirmed: no lint issues)eas goand verify credentials setup + workflow trigger still work