Use yarn --version to determine if modern yarn#3503
Open
yzhang-stytch wants to merge 2 commits intoexpo:mainfrom
Open
Use yarn --version to determine if modern yarn#3503yzhang-stytch wants to merge 2 commits intoexpo:mainfrom
yzhang-stytch wants to merge 2 commits intoexpo:mainfrom
Conversation
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas-cliwas failing for us in CI because it was using yarn 1 install command parameters when we are using yarn 4. The logic for determining whether.yarnrcexists should have worked for us, so I'm not entirely sure why the old logic stopped working.How
On the other hand just asking
yarnwhich version it is would work better than trying to infer it from the presence of an rc file. There's nothing else that tries to read the rc file so I think this should be strictly better.Test Plan
yarn --versionreturns just a version string for both classic and berryspawn