fix: remove setuptools runtime dependency#973
Open
arturict wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #971.
What changed
Removed
setuptoolsfrominstall_requiresinsetup.cfg.Why
setuptoolsis a build-time dependency for Thinc and remains correctly declared in the PEP 517[build-system]requirements inpyproject.toml. It is not imported by Thinc at runtime, so listing it ininstall_requiresunnecessarily installs it into user environments as a runtime dependency.Validation
setup.cfgwith PythonConfigParserand verified the runtime dependency list still contains 11 entries, includes NumPy, and no longer includessetuptoolsgit diff --checkA full wheel build was not run because the local environment does not have the repository's Cython/NumPy build toolchain installed. The build-system declaration itself is unchanged.