Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed against the focus areas (boot safety, device/build pin, kernel config, KernelSU module lifecycle, ext4 loop mounting, Docker startup, Wi-Fi routing, packaging, accidental firmware/credential/artifact inclusion). This PR's only effective change relative to
mainis this version bump — no other tracked file differs.Checked this specific change for correctness:
versionCode8→9 is a valid monotonic increase, matching^[1-9][0-9]*$as required bymodule/uninstall.sh's strictread_module_versionawk parser (module.prop line 4) andtools/assemble-module.py'sinstaller_positive_integercheck.version=0.1.0-rc.7matches^[A-Za-z0-9][A-Za-z0-9._+-]*$(uninstall.sh line 3 check and assemble-module.py'sSAFE_NAME_PATTERN), and the file is still exactly 6 lines, satisfying the parser'sNR != 6end check.0.1.0-rc.6orversionCode=8that needed updating (tests/simple-installer.test.mjsuses an unrelated self-contained fixture with its own0.1.0-rc.5/8, not read from this file).git ls-filesshows no firmware images, boot images, keys, or generated build artifacts committed;.gitignorealready excludesartifacts/,kernel/out/,deployment/payload/,*.apk,*.jks,*.keystore.DEVICE.json/kernel/builds.jsonstill consistently pinakita/CP2A.260805.005, unaffected by this change.No actionable correctness or regression issue found in this diff.