Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions module/module.prop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
id=eip-pixel8a-forge
name=EIP Pixel 8a Forge
version=0.1.0-rc.6
versionCode=8
version=0.1.0-rc.7
versionCode=9
Comment on lines +3 to +4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the focus areas (boot safety, device/build pin, kernel config, KernelSU module lifecycle, ext4 loop mounting, Docker startup, Wi-Fi routing, packaging, accidental firmware/credential/artifact inclusion). This PR's only effective change relative to main is this version bump — no other tracked file differs.

Checked this specific change for correctness:

  • versionCode 8→9 is a valid monotonic increase, matching ^[1-9][0-9]*$ as required by module/uninstall.sh's strict read_module_version awk parser (module.prop line 4) and tools/assemble-module.py's installer_positive_integer check.
  • version=0.1.0-rc.7 matches ^[A-Za-z0-9][A-Za-z0-9._+-]*$ (uninstall.sh line 3 check and assemble-module.py's SAFE_NAME_PATTERN), and the file is still exactly 6 lines, satisfying the parser's NR != 6 end check.
  • No other tracked file hardcodes the old string 0.1.0-rc.6 or versionCode=8 that needed updating (tests/simple-installer.test.mjs uses an unrelated self-contained fixture with its own 0.1.0-rc.5/8, not read from this file).
  • git ls-files shows no firmware images, boot images, keys, or generated build artifacts committed; .gitignore already excludes artifacts/, kernel/out/, deployment/payload/, *.apk, *.jks, *.keystore.
  • DEVICE.json / kernel/builds.json still consistently pin akita / CP2A.260805.005, unaffected by this change.

No actionable correctness or regression issue found in this diff.

author=Exploit Intel
description=Pixel 8a Docker host installer (Wi-Fi only)