Compare code readiness against the catalog checkpoint - #13
Conversation
|
Reviewed this PR against the corpus-injection / derived-judgment / fail-open checklist. Scope: Checked in detail:
One non-blocking note: No findings that meet the bar for inline comments. |
|
Review disposition: no significant findings from the independent reviews or CI review. The historical readiness fixture does omit the catalog checkpoint, as noted; refreshing that general fixture is real but outside this targeted correction. The new tests explicitly exercise catalog/index equality, inequality, absent fields, API failure status and full-value comparison before display truncation. The unchanged fixture additionally retains missing-field coverage. All quality and package checks passed. |
Readiness incorrectly compared the code index with the whole-corpus checkpoint, reporting possible missing code after enrichment alone advanced that checkpoint. Compare the index with the API's code-search catalog checkpoint, show both identities and preserve the API's subsystem status. Missing comparison inputs do not imply either a match or a mismatch.
Tests cover matching catalogs with differing corpus revisions, actual catalog mismatches, missing fields and comparisons before display truncation. Prepare package version 3.0.2 for the required release artifact; this PR does not tag or publish a release.
Validation: Ruff, formatting and mypy passed; 1,973 tests passed, 232 skipped, 97.34% coverage. Wheel and sdist build and twine validation passed. Three independent review lenses found no significant issues. The deployed formatter will be checked against live API checkpoint identities after release and deployment.