Name this eip-mcp everywhere, including the deploy templates - #10
Conversation
The repository, PyPI distribution and canonical executable have been eip-mcp since 3.0.0, and AGENTS.md says so three lines under a title that still read eip-mcp-v3. The deploy templates never followed: deploy/systemd shipped eip-mcp-v3.service and eip-mcp-v3.env.example installing to /opt/eip/eip-mcp-v3 and executing the legacy alias, and docs/self-hosting.md walked a public reader through that whole procedure. Production has run eip-mcp at /opt/eip/eip-mcp since 2026-08-17, so anyone following the self-hosting guide built something that did not match the project. The renamed unit is now byte-for-byte the shape of the unit ovh2 actually runs, which I checked against the host rather than assuming. Three more claims were wrong. AGENTS.md gave the SDK range as mcp>=2.0.0,<3; pyproject pins <2.1 since 2.1.0 stopped propagating messages raised during argument validation. It described declared_arguments.py as the ledger tying parameters to effects, when that module is the gate refusing undeclared arguments and its own docstring says there is deliberately no second list; the ledger is in tests, as AGENTS.md correctly says elsewhere. And it said pagination was unreachable on "all three paginated tools" when ten declare a cursor, so the count is dropped rather than left to rot again. tests/test_host_allowlist_matching.py referenced the old template filename and now matches; that it failed on the rename is the test doing its job.
|
Reviewed against the checklist for this repo (corpus-text escaping, derived judgments, stored-analysis fail-open, PoC token leakage, unbounded output, fabricated values, host-validation/transport-security weakening, scope creep). None of that surface is touched here — this is a pure naming/doc consistency fix ( Spot-checked the two corrected factual claims directly against source rather than taking the PR description at face value:
Also confirmed no stale No functional or security-relevant behavior changes. No inline comments. |
1 participant
The repository, PyPI distribution and canonical executable have been
eip-mcpsince 3.0.0.AGENTS.md:3-4says so, three lines under a title that still read# eip-mcp-v3.The part that reaches users
deploy/systemd/shippedeip-mcp-v3.serviceandeip-mcp-v3.env.example, installing to/opt/eip/eip-mcp-v3and executing the legacy alias console script.docs/self-hosting.mdwalked a public reader through that entire procedure.Production has run
eip-mcpat/opt/eip/eip-mcpsince 2026-08-17, so anyone following the published self-hosting guide built something that did not match the project or its own documentation.I checked the renamed unit against what ovh2 actually runs rather than assuming:
Identical. The
eip-mcp-v3console script stays as the legacy alias, which is deliberate and documented.Three more wrong claims
AGENTS.md:77SDKmcp>=2.0.0,<3pyproject.toml:25pins<2.1, since 2.1.0 stopped propagating messages raised during argument validationdeclared_arguments.pyis "the ledger tying every declared parameter to an observable effect"tests/, asAGENTS.md:128-129already sayscursor. Count dropped so it cannot rot againVerification
1970 passed, 232 skipped, ruff clean.
tests/test_host_allowlist_matching.py:31referenced the old template filename and failed on the rename, which is the test doing its job; it now matches.The auditor separately confirmed the 19-tool list, that all 19 carry the read-only annotation, and every documented bound and env default.