Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer lags and frequencies currently fail when the floating-point kernel result is added to an integer output array:
Promote evaluation inputs to at least float64 before taking absolute values or squaring. This also avoids overflow at the minimum signed integer and during integer frequency squaring. Preserve extended floating precision, and apply the same promotion to the exposure-convolution wrappers so their intermediate calculations use the promoted dtype.
Tests cover real, complex, SHO and convolved kernels, integer and float32 arrays, integer extrema and extended precision. The native/core suite passes with 10 optional-backend skips, and all configured pre-commit hooks pass. Separate sampled-signal workflows match analytic covariance/spectral references and SciPy dense solves; the existing float64 native inference results remain identical.