Ease contribution with Devcontainer - #1041
Open
mk-mxp wants to merge 3 commits into
Open
Conversation
PHPUnit cannot be used directly, the extension does not work for us. PHPCS extension requires advanced setup to be used in a container, so don't provide it.
mk-mxp
added
x:action/improve
homersimpsons
approved these changes
Aug 3, 2026
Comment on lines
+7
to
+13
| # ds is pinned to v1, since v2 (the only version building against PHP 8.4 via | ||
| # PECL/docker-php-ext-install) dropped Vector/Deque/Stack/Queue/PriorityQueue. | ||
| RUN curl -L -o install-php-extensions \ | ||
| https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions \ | ||
| && chmod +x install-php-extensions \ | ||
| && ./install-php-extensions gmp ds-^1@stable intl \ | ||
| && rm install-php-extensions |
Contributor
There was a problem hiding this comment.
Should we instead upgrade the test runner and everything to V2 ? Or would you prefer doing this in the php 8.5 upgrade ?
Note that even if they were removed, new alternatives were provided https://github.com/php-ds/ext-ds/releases/tag/v2.0.0
| - PHP V8.4+ CLI, with the following extensions: | ||
| - `ds` (V1.x) | ||
| - `intl` | ||
| - Default modules: `Core`, `ctype`, `date`, `dom`, `fileinfo`, `filter`, `hash`, `iconv`, `json`, `libxml`, `mbstring`, `pcre`, `random`, `Reflection`, `SimpleXML`, `sodium`, `SPL`, `standard`, `tokenizer`, `xml`, `xmlreader`, `xmlwriter`, `zlib` |
Contributor
There was a problem hiding this comment.
Shouldn't we just mention ext-* requirements? It does not look relevant to mention "Core", "ctype", "date"...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a Devcontainer setup for contributors. This provides all required PHP modules / extensions.