Skip to content

queen-attack: predefined errors #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keiravillekode merged 1 commit into from
Jun 6, 2026
Merged

queen-attack: predefined errors #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions exercises/practice/queen-attack/.meta/example.factor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
USING: accessors kernel locals math ;
IN: queen-attack

ERROR: row-not-on-board ;
ERROR: column-not-on-board ;

TUPLE: queen row column ;

:: <queen> ( row column -- queen )
row 0 < [ "row not positive" throw ] when
row 7 > [ "row not on board" throw ] when
column 0 < [ "column not positive" throw ] when
column 7 > [ "column not on board" throw ] when
row 0 < row 7 > or [ row-not-on-board ] when
column 0 < column 7 > or [ column-not-on-board ] when
row column queen boa ;

:: can-attack? ( queen1 queen2 -- ? )
Expand Down
5 changes: 3 additions & 2 deletions exercises/practice/queen-attack/.meta/generator.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ function gen_test_case(case)
column = Int(pos["column"])
expected = case["expected"]
if expected isa AbstractDict
msg = expected["error"]
return """[ $(row) $(column) <queen> ]\n[ "$(escape_factor(msg))" = ] must-fail-with"""
pred = occursin("row", expected["error"]) ?
"row-not-on-board?" : "column-not-on-board?"
return """[ $(row) $(column) <queen> ]\n[ $(pred) ] must-fail-with"""
else
return """[ $(row) $(column) <queen> drop ] must-not-fail"""
end
Expand Down
8 changes: 4 additions & 4 deletions exercises/practice/queen-attack/queen-attack/queen-attack-tests.factor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ STOP-HERE

"queen must have positive row" description
[ -2 2 <queen> ]
[ "row not positive" = ] must-fail-with
[ row-not-on-board? ] must-fail-with

"queen must have row on board" description
[ 8 4 <queen> ]
[ "row not on board" = ] must-fail-with
[ row-not-on-board? ] must-fail-with

"queen must have positive column" description
[ 2 -2 <queen> ]
[ "column not positive" = ] must-fail-with
[ column-not-on-board? ] must-fail-with

"queen must have column on board" description
[ 4 8 <queen> ]
[ "column not on board" = ] must-fail-with
[ column-not-on-board? ] must-fail-with

"cannot attack" description
{ f } [ 2 4 <queen> 6 6 <queen> can-attack? ] unit-test
Expand Down
3 changes: 3 additions & 0 deletions exercises/practice/queen-attack/queen-attack/queen-attack.factor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
USING: kernel ;
IN: queen-attack

ERROR: row-not-on-board ;
ERROR: column-not-on-board ;

: <queen> ( row column -- queen )
"unimplemented" throw ;

Expand Down
Loading