Repository navigation
Configure trusted forwarded header peers #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+679
−13
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f47cdb4
Configure webhook delivery options
niemyjski 537354e
Preserve webhook destinations and exception diagnostics
niemyjski 08c6d4f
Simplify webhook delivery test repository mocks
niemyjski ae5012b
Preserve safe webhook diagnostics and pooled client lifetimes
niemyjski 86a229f
Remove webhook delivery doc and use JSON pattern matching
niemyjski 0a1fe69
Prevent OTel context propagation to webhook receivers
niemyjski 54fd0c0
Simplify webhook disposal and reuse shared test logging
niemyjski 47f8904
Configure trusted forwarded header peers
niemyjski 9679428
Clarify forwarded header compatibility and align code style
niemyjski 830924d
Support disabling forwarded headers and cover proxy boundaries
niemyjski 3759784
Merge main after webhook delivery merge into forwarded headers
niemyjski 5a72699
Validate forwarded peer settings and clarify hosting migration
niemyjski 2b5137c
Discover gateway trust during dev and prod deployment
niemyjski a8368d3
Remove CI tooling tests and use JavaScript modules by default
niemyjski 4c00198
Merge remote-tracking branch 'origin/main' into feature/update-stack-…
niemyjski 370d284
Harden and clarify gateway trust discovery
niemyjski 6a79c55
Harden forwarded-header discovery output
niemyjski d48b97a
Enforce script braces and reject unrestricted forwarding
niemyjski 7408a77
Use JavaScript module extensions and shared script linting
niemyjski 0402e2c
Merge local main lint cleanup and reuse shared ESLint configuration
niemyjski 8c88687
Sync amended local main and remove root package manifest
niemyjski 711caec
Limit pull request to forwarded header security changes
niemyjski 8addb15
Group forwarded header settings and document framework keys
niemyjski 0e7e925
Clarify explicit forwarded header configuration binding
niemyjski 6c3d290
Separate trusted proxy options from middleware configuration
niemyjski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
deployjob has noactions/setup-nodestep, unlike the other jobs that explicitly select Node 24. The new.jsscript uses top-level ESM imports, but the repository has no ancestorpackage.jsondeclaring"type": "module"; Node's package documentation notes that syntax detection for ambiguous.jsfiles became enabled by default only in Node 22.7. On a runner exposing Node 20 or older, both this development invocation and the production invocation fail withCannot use import statement outside a modulebefore Helm runs, so the deploy job should select Node 24 explicitly.Useful? React with 👍 / 👎.