Expand Playwright operator workflow coverage#2367
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2b54f85af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| await test.step('open event details from the Events table', async () => { | ||
| await page.goto('/next/stack'); | ||
| await page.getByRole('link', { exact: true, name: 'Events' }).filter({ visible: true }).first().click(); |
There was a problem hiding this comment.
For an organization after the saved-views query completes, the dashboard parent no longer renders as a link: the sidebar renders routes with children as a collapsible button, and predefined saved views add children under Events. In that state this locator never matches and the new spec can time out before reaching the direct goto, making the test race-prone on fast or warm runs; click the parent button plus a child view such as All, or navigate directly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in fbf0d20. The test now uses a shared sidebar helper that supports both direct-link parents and collapsible parents with saved-view children. Verified with the focused operator-navigation Playwright test (1 passed).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0690476f5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
|
|
||
| await test.step('redirect a signed-out user away from a protected route', async () => { | ||
| await page.goto('/next/stack'); |
There was a problem hiding this comment.
This spec uses e2eScenario, whose fixture installs a page.addInitScript that writes satellizer_token on every full navigation. After the logout step clears storage, this page.goto('/next/stack') runs that init script again, so the app is re-authenticated before the protected route loads and the redirect-to-login assertion can fail or stop testing a signed-out user. Use a setup path that does not inject the token for this spec, or clear storage after this navigation with a fresh unauthenticated context.
Useful? React with 👍 / 👎.
|
1 participant
Summary
Verification
npm run checknpx eslint e2enpm run lint:prettier -- --check e2enpm run test:e2e:local -- --workers=1(9 passed)Breaking changes
None.