Skip to content

Remove lint:dependencies usage from report.yml and add deprecation notice #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArBridgeman merged 1 commit into from
Jul 10, 2026
Merged

Remove lint:dependencies usage from report.yml and add deprecation notice #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/report.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions doc/changes/unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased

## Summary

## Refactoring

* #924: Removed `lint:dependencies` usage from `report.yml` and added deprecation notice
8 changes: 8 additions & 0 deletions exasol/toolbox/nox/_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
from exasol.toolbox.util.dependencies.shared_models import PoetryFiles
from noxconfig import PROJECT_CONFIG

# The relevant nox session will be removed in:
# https://github.com/exasol/python-toolbox/issues/924
LINT_DEPENDENCIES_DEPRECATION_DATE = "2026-10-08"


def _pylint(session: Session, files: Iterable[str]) -> None:
json_file = PROJECT_CONFIG.root_path / ".lint.json"
Expand Down Expand Up @@ -149,6 +153,10 @@ def dependency_check(session: Session) -> None:
if illegal := dependencies.illegal:
report_illegal(illegal, console)
sys.exit(1)
session.warn(
f"Warning: `nox -s lint:dependencies` is deprecated and will be removed on "
f"{LINT_DEPENDENCIES_DEPRECATION_DATE}."
)


@nox.session(name="lint:import", python=False)
Expand Down
6 changes: 0 additions & 6 deletions exasol/toolbox/templates/github/workflows/report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,3 @@ jobs:
env:
SONAR_TOKEN: "${{ secrets.(( sonar_token_name )) }}"
run: poetry run -- nox -s sonar:check

- name: Generate GitHub Summary
id: generate-github-summary
run: |
echo -e "# Summary\n" >> $GITHUB_STEP_SUMMARY
poetry run -- nox -s dependency:licenses >> $GITHUB_STEP_SUMMARY