Feature/922 make permissions configurable for custom workflows#923
Feature/922 make permissions configurable for custom workflows#923ArBridgeman wants to merge 12 commits into
Conversation
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
force-pushed
the
feature/922_make_permissions_configurable_for_custom_workflows
branch
from
10e54e9 to
3b03bca
Compare
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
… be handled separately
- This is already present in the CLI of the nox sessions workflow:check and workflow:generate - This is already required by the WorkflowOrchestrator which is a pydantic model which restricts WorkflowChoice and hard-code maps it to the right values.
ArBridgeman
force-pushed
the
feature/922_make_permissions_configurable_for_custom_workflows
branch
from
1eae0d1 to
69e8d14
Compare
ArBridgeman
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
ArBridgeman
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
| Render the selected workflows and write them to disk. | ||
| """ | ||
| for workflow in self._iter_workflows(): | ||
| # First, generate not-maintained workflows for a new project. |
There was a problem hiding this comment.
This was actually an unidentified bug in the setup. So when we just had secrets, it went unnoticed as the default slow-checks.yml doesn't have secrets that need to be passed. However, as permissions should always be set to adhere to the best security practices; it's best that we separate the two workflow types PTB-controlled vs custom at a higher level.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69e8d1492a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…r_custom_workflows
ArBridgeman
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
|
1 participant
closes #922
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: